Closed kousu closed 5 years ago
coveralls
commented
6 years ago Coverage increased (+0.03%) to 95.297% when pulling 4bd6e7b4c5435c6c7e08aafc2dc5df0c1d18dd65 on santropolroulant:dev into 396f86d696fd1dc541b6556dacea8a621e2b7420 on savoirfairelinux:dev.
erozqba
commented
6 years ago @JeanFrancoisFournier are you OK with renaming "Diabetic Dessert" to "Diabetic" to work around #833?
kkonieczny
commented
5 years ago @erozqba is this MR still relevant?
erozqba
commented
5 years ago @kkonieczny no idea, I make a question to @JeanFrancoisFournier but no anwser.
JeanFrancoisFournier
commented
5 years ago Perfectly fine with the work around solution. I actually suggested it to Nick.
The "diabetic dessert" text was changed to just "diabetic" by @kousu. This is all we needed to avoid confusing with the volunteers using the route sheets with this line break issue.
The only issue remaining with this is that if in the future, the kitchen crew decided to add a new side dish option for clients, they would have to limit the length of the name for that side dish to avoid line break issues again. (i.e. no long names).
Hope that answers your question and Thanks!
JeanFrancoisFournier
commented
5 years ago Hi Ernesto,
Sorry, I made a comment on the GitHub. Maybe it was not the right place to answer. Maybe not the right issue commented either... sorry
Just commented right below you on issue #837
Thanks again for your support!
-- https://www.santropolroulant.org/
Jean-François Fournier
Coordonnateur de la Communauté de Clients de la Popote-Roulante Coordinator of the Meals-on-Wheels Client Community 514 284-9335 <514-284-9335>
Nourish your community - become a monthly donor https://santropolroulant.org/en/2017/05/2017-monthly-giving-campaign-roulant-roots/
http://www.facebook.com/sroulant http://twitter.com/SRoulant http://instagram.com/SRoulant https://www.linkedin.com/company/santropol-roulant https://www.youtube.com/channel/UCFYRQO2HSNs6wJMA1as5zhg https://santropolroulant.org/publications/newsletters/ https://www.canadahelps.org/dn/12292
On Mon, Jan 28, 2019 at 9:22 AM Ernesto Rodriguez Ortiz < notifications@github.com> wrote:
@kkonieczny https://github.com/kkonieczny no idea, I make a question to @JeanFrancoisFournier https://github.com/JeanFrancoisFournier but no anwser.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/savoirfairelinux/sous-chef/pull/837#issuecomment-458150145, or mute the thread https://github.com/notifications/unsubscribe-auth/AU8MC-cumhKQdjc6Q03ghtkrn6nTVg60ks5vHwevgaJpZM4VDAna .
kousu
commented
5 years ago Hey all, this PR has been languishing. It looks like it has the approval of @JeanFrancoisFournier. I'd appreciate if @erozqba or @JeanFrancoisFournier could click the Merge button.
erozqba
commented
5 years ago @kousu I would love to, but I don't have access to do that. I'm not longer at Savoir-faire Linux and my permissions to approve PR has been removed. @kkonieczny could you take care of this?
JeanFrancoisFournier
commented
5 years ago @kousu and @erozqba Is it as easy as clicking the "Merge pull request" button. I can so that now!
Works around #833 by shortening the name
Status
How to verify this change
Fill out this section so that a reviewer can know how to verify your change.
Stop your docker instance, if applicable, pull the code, and put your docker instance back up if applicable. Run the migration:
cd src; python manage.py migrateRe-print the kitchen count. It should now be laid out like Diabetic 2 Green Salad 3
Deployment notes and migration
New translatable strings
Additional notes
This is not the final patch for #833; as I explained on that ticket, there's a deeper problem here. But it fixes the problem for now, and that's all we need.