It turns out that add_item is not used, so the clients are always billed with the proper prices. It must have been part of a refactoring initiative that did not finish.
Changes proposed in this pull request:
🔥
Remove add_item, remove_item and cancel methods
Remove corresponding test cases. remove_item and cancel were not tested.
Status
[X] READY
[ ] HOLD
[ ] WIP (Work-In-Progress)
Additional notes
I let you decide if you want to merge that or not. In my opinion, it's better to remove dead code, as it can lead to confusion.
Coverage decreased (-0.07%) to 95.28% when pulling 3cfcf29bf12c8e153608eedc9531b22ffd099b1c on manumilou:remove-unused-methods into 0359baf61a836681f1a5bdd8e0956445c89acfc6 on savoirfairelinux:dev.
Tackles #842
It turns out that
add_item
is not used, so the clients are always billed with the proper prices. It must have been part of a refactoring initiative that did not finish.Changes proposed in this pull request:
🔥
add_item
,remove_item
andcancel
methodsremove_item
andcancel
were not tested.Status
Additional notes
I let you decide if you want to merge that or not. In my opinion, it's better to remove dead code, as it can lead to confusion.