search

savoirfairelinux / vanilla-slick

Soon! The vanilla JavaScript version of the last carousel you'll ever need!
MIT License
5 stars 1 forks source link

Debug fadeslide #25

Open ubik23 opened 8 years ago

ubik23 commented 8 years ago

Pull request for two methods: fadeSlide and fadeSlideOut

How to test: change the useCSS flag to false for the js animation to take over, open the demo and cycle through the slider under the 'Fade' header.

Note: There are two comments labeled 'TODO' as a reminder to add support for easing and polyfill for requestAnimationFrame.

pieplu commented 8 years ago

@ubik23 I found for the test broken. If you see your commit, the build fail when you add requestAnimationFrame. On travis, the firefox version is 31 and it's look like it's buggy for this version https://bugzilla.mozilla.org/show_bug.cgi?id=1048196 (and 30 too, I test it on my laptop).