Vaalyn
commented
2 years ago I have broken down the generated Liquidsoap script in order to replicate this issue and found that the short script seems to not cause this double-fetching when I call local_3.skip or dynamic_startup.skip.
Here is the short script I built:
init.allow_root.set(true)
init.daemon.set(false)
init.daemon.pidfile.path.set("/var/azuracast/liquidsoap-test.pid")
log.stdout.set(true)
log.file.set(false)
settings.server.telnet.set(true)
settings.server.telnet.bind_addr.set("0.0.0.0")
settings.server.telnet.port.set(8104)
settings.harbor.bind_addrs.set(["0.0.0.0"])
settings.tag.encodings.set(["UTF-8","ISO-8859-1"])
settings.encoder.metadata.export.set(["artist","title","album","song"])
setenv("TZ", "Europe/Berlin")
autodj_is_loading = ref(true)
ignore(autodj_is_loading)
autodj_ping_attempts = ref(0)
ignore(autodj_ping_attempts)
# AutoDJ Next Song Script
def autodj_next_song() =
uri = list.hd(default="", process.read.lines('php /var/azuracast/test.php'))
log("Raw Response: #{uri}")
if uri == "" or string.match(pattern="Error", uri) then
[]
else
r = request.create(uri)
if request.resolve(r) then
[r]
else
[]
end
end
end
# Delayed ping for AutoDJ Next Song
def wait_for_next_song(autodj)
autodj_ping_attempts := !autodj_ping_attempts + 1
delay = ref(0.5)
if source.is_ready(!autodj) then
log("AutoDJ is ready!")
autodj_is_loading := false
delay := -1.0
elsif !autodj_ping_attempts > 200 then
log("AutoDJ could not be initialized within the specified timeout.")
autodj_is_loading := false
delay := -1.0
end
!delay
end
dynamic = mksafe(request.dynamic.list(id="next_song", timeout=20., retry_delay=2., autodj_next_song))
dynamic = cue_cut(id="cue_next_song", dynamic)
radio = fallback(
id = "dynamic_startup",
track_sensitive = false,
[
dynamic,
source.available(
blank(id = "autodj_startup_blank", duration = 120.),
predicate.activates({!autodj_is_loading})
)
]
)
ref_dynamic = ref(dynamic);
thread.run.recurrent(delay=0.25, { wait_for_next_song(ref_dynamic) })
add_skip_command(radio)
output.icecast(%mp3(samplerate=44100, stereo=true, bitrate=128, id3v2=true), id="local_3", host = "127.0.0.1", port = 8000, password = "na4R2NKn", mount = "/test", name = "Blah", description = "A test radio station.", genre = "Test Genre", public = true, encoding = "UTF-8", radio)The php script that I call with list.hd(default="", process.read.lines('php /var/azuracast/test.php')) looks like this:
<?php
file_put_contents(__DIR__ . '/debug.txt', time() . PHP_EOL, FILE_APPEND);
$songs = [
'annotate:title="No Better Feelin\'",artist="Lee Chae-rin",duration="173.00",liq_amplify="0.00dB":/var/azuracast/stations/azuratest_radio/media/MLP Movie Soundtrack/11 - No Better Feelin\'.mp3',
'annotate:title="I\'m The Friend You Need",artist="Daniel Ingram",duration="135.00",liq_amplify="0.00dB":/var/azuracast/stations/azuratest_radio/media/MLP Movie Soundtrack/02 - I\'m The Friend You Need.mp3',
'annotate:title="I\'ll Be Around",artist="Palmer Reed",duration="229.00",liq_amplify="0.00dB":/var/azuracast/stations/azuratest_radio/media/MLP Movie Soundtrack/12 - I\'ll Be Around.mp3',
'annotate:title="Time To Be Awesome",artist="Daniel ingram",duration="173.00",liq_amplify="0.00dB":/var/azuracast/stations/azuratest_radio/media/MLP Movie Soundtrack/03 - Time To Be Awesome.mp3',
];
echo $songs[array_rand($songs)];With the file_put_contents at the top of the PHP script I'm checking the timestamps when the script was called to see if there are multiple entries at the same time which would indicate double-fetching.
toots
Describe the bug When sending a
skipcommand via telnet to a LS process that is usingrequest.dynamic.listwith the defaultprefetchof1I'm seeing it sending 2 requests to my API that returns the next song.To Reproduce I'm currently working on an update for AzuraCast to use Liquidsoap 2.0 and noticed this issue so I don't yet have a simplified example. I hope that the LS script we generate can help somewhat:
The specific telnet command that is sent is:
requests_fallback.skipExpected behavior When sending a
skipvia telnet therequest.dynamic.listshould only call the given function as often as needed to fill the defined amount of prefetched songs.Version details
Install method Opam from the GitHub source. See: https://github.com/AzuraCast/docker-azuracast-radio/blob/bddd4d1cae39db628de1a832355e8f1c887b0fa1/Dockerfile
Please let me know if you need anything (for example: specific logs from a specific log level) and I'll get them.