Open Groschi opened 2 years ago
Maybe related to #2057?
Maybe related to #2057?
Sounds likely, although i haven't noticed any actual duplicates being played. Might be sheer luck though - i'm gonna have to comb through last week's log files a bit to see if that's the case.
edit I went through the logs and couldn't find any smoking gun duplicates between re-loads or liquidsoap restarts. Guess i'm just gonna wait for a 2.1.x release to see if the problem still persists then. Thanks for the superfast, hopefully successful fix. Fingers crossed. :smile:
After I had been observing that strange "randomize" behavior for a long time too, I've been testing the relevant patch for 2.1.0 with the modified list.liq (commit ac4233e) in 2.0.6. It looks quite good so far.
Since 2.0.7 should be released soon, I wonder why this patch isn't planned there so far...
This is my fault, I forgot to add it to the realease... I just did it in f2a87e7a906464a89bd1bf7917d7b5269d6039ce. As you can see the diff is real small and easy to implement on your local version in the meantime.
Just upgraded to 2.1.0. So far everything looks fine here aswell.
Describe the bug I've repeatedly noticed lately (probably since version 2.0.0, although i'm not entirely sure at what exact version the problem started - it was certainly an issue with 2.0.2 and has stayed the same after updating to 2.0.6) that
playlist(mode="randomize")
starts out not very random after (re-)loading the playlist. Instead there are clear patterns and unusually frequent artist repetitions going on. So far, whenever i've checked again the next day, things seemed to have calmed down by then and the song picks felt reasonably random again. To give you an impression of the problem, here are some log excerpts.The "rotation" playlist is the wildest example here. You'll sure notice that each track played here has a filename starting with a letter in the M-Z range. Weird stuff! Plenty of files starting with m, n, o, p, - then there are few-to-none with r, s, t... then we're going wild in the u-z range again. Also, there are way more artist repetitions than you'd expect from a directory containing roughly 17500 tracks. Since this is the largest of my three playlists, it sure looks like this problem gets triggered more heavily when loading large playlists/directories.
The "classics" playlist (containing ~8000 tracks) ain't quite as bad but you can notice obvious patterns and artist repetitions here too... in addition to an unlikely abundance of tracks whose filenames start with "De..." or "Di...".
The "new" playlist is the shortest here (~1600 tracks) but shows the same familiar weirdness:
To Reproduce I can't really tell what's actually triggering the problem. This is the script i'm running:
Note: I set
prefetch=5
purely for testing purposes. The behaviour was the same when i left out theprefetch
option. The hardware is a 8 GB raspberry pi 4. Debian/RaspberryOS is booted from an external SSD connected via USB 3. The audio files are stored on an external hard drive, also connected via USB 3.This is all i can give you to work with right now. Please let me know what other kind of more verbose or specific log data would be helpful to narrow things down.
As far as i understand, mode=randomize generates a full shuffled sequence of tracks when the playlist is loaded, right? Is there a way to make liquidsoap output the full track order?
Expected behavior
You'd expect the playback order to look and feel reasonably random.
Version details
Install method opam