vitoyucepi
commented
7 months ago I would like to bump this issue with a new reproduction and my explanation of the problem.
Summary
If the number of requests in request.dynamic is less than the prefetch value, but greater than 0, request.dynamic tries to get new requests ~as fast as possible~ every frame.
Reproduction
t = ref(true)
def next()
print("Next called #{time.up()}")
if t() then
t := false
request.create("/tmp/test/music/1.mp3")
else
null()
end
end
q = request.dynamic(next, retry_delay=10.)
output.dummy(q, fallible=true)Expected behavior
Log
``` liquidsoap-1 | Next called 4.01913905144 liquidsoap-1 | Next called 4.05933594704 liquidsoap-1 | Next called 14.018157959 liquidsoap-1 | Next called 24.0980420113 ```Current behavior
Log
``` liquidsoap-1 | Next called 4.01913905144 liquidsoap-1 | 2024/03/05 20:56:55 [dummy:3] Content type is {audio=pcm(stereo)}. liquidsoap-1 | 2024/03/05 20:56:55 [request.dynamic:3] Content type is {audio=pcm(stereo)}. liquidsoap-1 | 2024/03/05 20:56:55 [clock.main:3] Streaming loop starts in auto-sync mode liquidsoap-1 | 2024/03/05 20:56:55 [clock.main:3] Delegating synchronization to CPU clock liquidsoap-1 | 2024/03/05 20:56:55 [video.converter:3] Using preferred video converter: ffmpeg. liquidsoap-1 | 2024/03/05 20:56:55 [audio.converter:3] Using samplerate converter: libsamplerate. liquidsoap-1 | 2024/03/05 20:56:55 [video.text:3] Using sdl implementation liquidsoap-1 | 2024/03/05 20:56:55 [decoder.ffmpeg:3] Requested content-type for "/tmp/test/music/1.mp3": {audio=pcm(stereo)} liquidsoap-1 | 2024/03/05 20:56:55 [decoder.ffmpeg:3] FFmpeg recognizes "/tmp/test/music/1.mp3" as audio: {codec: mp3, 44100Hz, 1 channel(s)} liquidsoap-1 | 2024/03/05 20:56:55 [decoder.ffmpeg:3] Decoded content-type for "/tmp/test/music/1.mp3": {audio=pcm(mono)} liquidsoap-1 | [mp3float @ 0x78020ae70400] Could not update timestamps for skipped samples. liquidsoap-1 | 2024/03/05 20:56:56 [request.dynamic:3] Prepared "/tmp/test/music/1.mp3" (RID 0). liquidsoap-1 | Next called 4.05933594704 liquidsoap-1 | Next called 4.09793996811 liquidsoap-1 | Next called 4.13802289963 liquidsoap-1 | Next called 4.17827296257 liquidsoap-1 | Next called 4.21839809418 ... liquidsoap-1 | Next called 13.4983170033 liquidsoap-1 | [mp3float @ 0x78020ae70400] Could not update timestamps for discarded samples. liquidsoap-1 | Next called 13.5384149551 liquidsoap-1 | 2024/03/05 20:57:05 [decoder:2] Decoding "/tmp/test/music/1.mp3" ended: Ffmpeg_decoder.End_of_file. liquidsoap-1 | Next called 13.5783839226 liquidsoap-1 | Next called 13.6181299686 liquidsoap-1 | Next called 13.6582930088 liquidsoap-1 | Next called 13.6981089115 liquidsoap-1 | Next called 13.7381300926 liquidsoap-1 | Next called 13.7780900002 liquidsoap-1 | Next called 13.8181099892 liquidsoap-1 | Next called 13.8581500053 liquidsoap-1 | Next called 13.8980360031 liquidsoap-1 | Next called 13.9381120205 liquidsoap-1 | Next called 13.9780828953 liquidsoap-1 | Next called 14.018157959 liquidsoap-1 | 2024/03/05 20:57:06 [dummy:3] Source failed (no more tracks) stopping output... liquidsoap-1 | Next called 14.0584609509 liquidsoap-1 | Next called 24.0980420113 ```Version
- OS: debain:12 in docker
- Version: 2.2.4-1
Install method
savonet/liquidsoap:v2.2.4
danbo
Describe the bug
Requests are being made when they shouldn't need to be during bad / error states. Related to #3026.
To Reproduce
Test script:
Expected behavior
Case 1
State: tcp endpoint down, no script changes, test mp3 file available
Expected behaviour: get_request should only be called when required, ie pre-fetch or the previous one is finishing, vs on error - only a reconnection should be happening on failure and not also a get_request. Streaming should just resume on the reconnected output once it becomes available if the request has already been made and is playing on the other output, ie dummy.
Log:
Case 2
State: output.external commented out, test mp3 filename changed to non-existent one / bad uri
Expected behaviour: get_request should be throttled to the retry_delay value, in the script's case - 5 seconds.
Log:
Version details
Install method Official docker images