Closed caturria closed 1 year ago
Hi @caturria,
Could you try to reproduce this problem with one of the newer versions? Currently, the latest version is 2.2.1. It would be great if you could also check against the main branch.
Hi, That is a typographical error on my part. I wrote 2.0.1 but meant to write 2.2.1. I'll just edit the comment.
Doesn't seem like I can edit it. But yes; the correct versions are 2.2.1 and 2.2.3.
Excuse me, but what does 2.2.3 mean? Just to clarify, there's a long line of versions every time you start liquidsoap. Could you copy and paste that part of the liquidsoap startup log?
My apologies for the errors. I have 2.2.1:
caturria@caturria:~$ liquidsoap --version
Liquidsoap 2.2.1+dev
Copyright (c) 2003-2023 Savonet team
Liquidsoap is open-source software, released under GNU General Public License.
See http://liquidsoap.info for more information.
I also tested with this particular branch:
https://github.com/savonet/liquidsoap/tree/fix-3318
as I was working with @Toots on https://github.com/savonet/liquidsoap/issues/3318#issuecomment-1732622841
This build is identified as 2.3.0, not 2.2.3 as I had incorrectly written:
Liquidsoap 2.3.0+git@373373cc7
Copyright (c) 2003-2023 Savonet team
Liquidsoap is open-source software, released under GNU General Public License.
See http://liquidsoap.info for more information.
Sorry again for the confusion; that's what I get for posting while in a rush.
Hi @caturria and thanks for reporting. Would you mind sending me this track?
Hi, I have sent it to your email.
Thank you.
Thanks I have it. I'm not able to reproduce yet. Could you share some logs with log.level := 4
added to your script? Thanks!
Sure thing. Logs: https://cloud.caturria.ca/s/4G3a3TFqWGspmHW Here's how it sounds for me: https://cloud.caturria.ca/s/JGo2c2aK4AnaKFq Thank you.
Thanks for reporting. The bug has been identified and fixed. It was due to some issues with how we use libsamplerate
. It had not shown up until the recent switch to the internal ogg decoder for ogg files (due to ffmpeg limitations decoding chained ogg streams). Should be fixed in main
and rolling-release-v2.2.x
.
The v2.2.3
release should happen fairly soon. Meanwhile, a good workaround is to use the ffmpeg
sampleate converter in your script:
settings.audio.converter.samplerate.converters := ["ffmpeg"]
Describe the bug Since at least Liquidsoap >= 2.0, quite a few of my audio tracks play back with steady pops and clicks. These tracks do not play like this in other software, when decoded directly via Ffmpeg, or in Liquidsoap versions before 2.0. I do not want to link to a copyrighted track here, however one of the tracks in question was privately sent to @Toots while discussing another issue. I can send this and other tracks that reproduce again if needed. Though this track is definitely hot (it maxes out at around -10 LUFS), its sample peak is -0.8 dB (it doesn't clip). I can play it (and several other tracks) back in Liquidsoap with no processing applied and get distorted results.
To Reproduce radio = single("MOT () - cloudy SEOUL( ).ogg") output.file(%wav, "test.wav", radio)
Expected behavior Track plays back glitch free (as it does in VLC, previous versions of Liq, etc). Version details
1.3.4
] 2.0.1, 2.0.3 Install method V2.0.1 installed via Opam. V2.0.3 installed from source.