savonet / liquidsoap

Liquidsoap is a statically typed scripting general-purpose language with dedicated operators and backend for all thing media, streaming, file generation, automation, HTTP backend and more.
http://liquidsoap.info
GNU General Public License v2.0
1.4k stars 130 forks source link

Convert duppy to lwt #814

Closed smimram closed 5 years ago

smimram commented 5 years ago

Since we don't have so much manpower, it might be a good idea to ditch our internal libraries when standard ones are available. For duppy, it might be a good idea to switch to lwt.

@toots What do you think about it?

toots commented 5 years ago

While a totally agree on removing dependencies duppy is my baby and I wouldn't remove that part first.. 😅

More seriously, here are a couple of reasons not to:

I'm gonna close this for these reasons. However, please note that I am 100% ready to cut through dependencies.

The number one that I have in mind is a total rewrite of the file decoders. We should just use ffmpeg bindings for audio and video content. For audio content we could even decide everything down to wave format in the protocol stack. That would remove a ton of external dependencies.

toots commented 5 years ago

Ha also, let's do that after the 1.4 release.. 🙂

smimram commented 5 years ago

Fair enough, I thought that duppy was more or less superseeded by lwt. If it's not the case then let's keep things this way. Concerning the library for decoders, I am not completely sure, let's discuss this. In the past having multiple bindings has allowed us to switch easily when there was a problem.