Compile failed on CentOS 8 Stream

[TheRealMattLear]

Hey @toots seeing some compilation failures on a CentOS 8 Stream system today.

I believe on this system pkg-config is failing the --exists test which could be part of the problem:

# bash-4.4$ if pkg-config --exists faad2; then echo 'exists'; else echo 'not found'; fi
# not found

Pinning commit from 2020 (2703482) solved the issue.

bash-4.4$ opam install -y faad fdkaac flac theora vorbis taglib mad lame cry samplerate liquidsoap
[NOTE] Package samplerate is already installed (current version is 0.1.6).
[NOTE] Package cry is already installed (current version is 0.6.7).
[NOTE] Package lame is already installed (current version is 0.3.6).
[NOTE] Package mad is already installed (current version is 0.5.2).
[NOTE] Package taglib is already installed (current version is 0.3.9).
[NOTE] Package vorbis is already installed (current version is 0.8.0).
[NOTE] Package theora is already installed (current version is 0.4.0).
[NOTE] Package flac is already installed (current version is 0.3.0).
[NOTE] Package fdkaac is already installed (current version is 0.3.2).
The following actions will be performed:
  ∗ install conf-faad  1      [required by faad]
  ∗ install faad       0.5.1
  ∗ install liquidsoap 2.0.3*
===== ∗ 3 =====

<><> Gathering sources ><><><><><><><><><><><><><><><><><><><><><><><><><><><><>
[faad.0.5.1] found in cache

<><> Processing actions <><><><><><><><><><><><><><><><><><><><><><><><><><><><>
[ERROR] The compilation of conf-faad failed at "/usr/local/mediacp/.opam/opam-init/hooks/sandbox.sh build pkg-config --exists faad2".

#=== ERROR while compiling conf-faad.1 ========================================#
# context     2.0.9 | linux/x86_64 | ocaml-base-compiler.4.08.1 | https://opam.ocaml.org#9a5d6274
# path        ~/.opam/4.08.1/.opam-switch/build/conf-faad.1
# command     ~/.opam/opam-init/hooks/sandbox.sh build pkg-config --exists faad2
# exit-code   1
# env-file    ~/.opam/log/conf-faad-94017-d2c37b.env
# output-file ~/.opam/log/conf-faad-94017-d2c37b.out

<><> Error report <><><><><><><><><><><><><><><><><><><><><><><><><><><><><><><>
┌─ The following actions failed
│ λ build conf-faad 1
└─
╶─ No changes have been performed

The packages you requested declare the following system dependencies. Please make sure they are installed before retrying:
    faad2-devel

[toots]

Yeah we switched to relying on pkg-config to detect faad but not all OS packages include it. You might want to install faad.0.5.0 instead, which does not rely on it.