search

savonet / ocaml-ffmpeg

OCaml bindings to the FFmpeg library.
http://www.liquidsoap.info/ocaml-ffmpeg/
GNU Lesser General Public License v2.1
48 stars 12 forks source link

Fix the opam file #18

Closed kit-ty-kate closed 6 years ago

kit-ty-kate commented 6 years ago

git submodule ... is needed for the devel version and libavformat-dev is required but not declared as depext.

kit-ty-kate commented 6 years ago

Also, a dependency towards bigarray is missing in the META file but I don't know how to handle your build system.

# #require "ffmpeg";;
/home/kit_ty_kate/.opam/4.06.1/lib/ffmpeg: added to search path
/home/kit_ty_kate/.opam/4.06.1/lib/ffmpeg/ffmpeg.cma: loaded
Error: Reference to undefined global `Bigarray'
toots commented 6 years ago

Thanks that looks great. The dependency on bigarray can be added via a AC_SUBST substitution on src/META.in in configure.ac. What version of OCaml was the first to split it out? I suppose it should be conditional on the compiler's version being greater or equal to that.

kit-ty-kate commented 6 years ago

What version of OCaml was the first to split it out?

What do you mean? AFAIK bigarray has always been outside the standard library but only entered the standard library in 4.07 (see https://github.com/ocaml/ocaml/blob/7c9c210884e1b46f21af5bb4dfab995bb3336cf7/Changes#L214)

toots commented 6 years ago

Ha, sorry I got it mixed up ;-) Ok, merging, thank you!

gndl commented 6 years ago

Thank you for these fixes. I encountered the problem with the Bigarray library quite recently. I "solved" the problem by migrating my projects from Oasis to Jbuilder. I did not understood the origin of the problem. Thanks again.