Mark TLSv1, TLSv1_1, TLSv1_2 as deprecated

craff commented 1 year ago

It also avoids compilation warning related to these deprecations (from C and from OCaml now).

TODO: can we turn off only the deprecation warning about TLSV, to avoid missing a new deprecated feature ?

There is this:

#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
...
#pragma GCC diagnostic pop

But this is GCC specific ? Cheers, Christophe

anmonteiro commented 1 year ago

I thought a bit about this, and I think I'm not a fan of this direction:

IMO this library should strive to provide safe, performant and up-to-date bindings to OpenSSL
as the OpenSSL package evolves upstream, we should evolve with it to guarantee we keep up with well-supported, secure APIs
hiding deprecations goes against this philosophy by placing the burden on our future selves to fix it when they're finally removed and we start having linking problems related to missing names

Instead, how about:

we make one last release with these APIs, which I suppose are needed for OpenSSL 1.0.2 compatibility (this statement needs checking)
we go in the direction of #59 after said release, refactor to new APIs and drop compatibility with old OpenSSL versions

what do you think?

anmonteiro commented 1 year ago

Thank you, I took the liberty to deprecate even older versions, and added a changes entry.

craff commented 1 year ago

Antonio Nuno Monteiro writes:

Thank you, I took the liberty to deprecate even older versions, and added a changes entry.

Thanks to you!

-- Christophe Raffalli tél: +689 87 23 11 48 web: http://raffalli.eu

Ce mail est signé avec pgp (Pièce jointe signature.asc, clef sur https://raffalli.eu/pgp) This mail is signed with pgp (Attachment signature.asc, key on https://raffalli.eu/pgp)

savonet / ocaml-ssl