bug fixes in c interface

savonet / ocaml-ssl

OCaml SSL bindings.

http://liquidsoap.info/ocaml-ssl/

Other

57 stars 48 forks source link

Closed craff closed 1 year ago

craff commented 1 year ago

While working on another PR I spotted 3 bugs (and one security issue)

access outside of the buffer is possible in Ssl.read and Ssl.write: start sign is not tested
ERR_clear_error() is missing in 4 places while it is required in the spec
a missing "_blocking" in my last PR

I don't think 3 separate PR are needed, as it is a small PR, but I can do it if you wish.

craff commented 1 year ago

Also spotted that my implementation for checking if flush must be retried is not correct. One must use BIO_should_retry().

craff commented 1 year ago

Antonio Nuno Monteiro writes:

Merged #118 into master.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

Great thanks for the reviews and merge!

-- Christophe Raffalli tél: +689 87 23 11 48 web: http://raffalli.eu

Ce mail est signé avec pgp (Pièce jointe signature.asc, clef sur https://raffalli.eu/pgp) This mail is signed pgp (Attachment signature.asc, clef on https://raffalli.eu/pgp)