Get version - Githubissues

savonet / ocaml-ssl

OCaml SSL bindings.

http://liquidsoap.info/ocaml-ssl/

Other

57 stars 48 forks source link

Get version #140

Closed craff closed 1 year ago

craff commented 1 year ago

For version prior to 3.0, I collate fix and patch and ignore release, as all this has been removed in 3.0
I could not use version has it is already used. Still I do not like Ssl.ssl_version a better name is welcome.

craff commented 1 year ago

Current, the workflow fails on ubuntu latest because the test uses openssl version to test the version, but the command is not installed (or not in the path) . Don't know the best fix ?

craff commented 1 year ago

Tried to add a depext to install openssl in the github workflow, but it does not work yet.

anmonteiro commented 1 year ago

Tried to add a depext to install openssl in the github workflow, but it does not work yet.

The OPAM tests seem fine, why is the depext needed?

anmonteiro commented 1 year ago

Thanks.

craff commented 1 year ago

There was a problem on nix-os on the GitHub workflow, openssl command was not found. I tried depext without success and forgot to remove it.

Le 10 juin 2023 19:01:25 GMT-10:00, Antonio Nuno Monteiro @.***> a écrit :

Tried to add a depext to install openssl in the github workflow, but it does not work yet.

The OPAM tests seem fine, why is the depext needed?

-- Reply to this email directly or view it on GitHub: https://github.com/savonet/ocaml-ssl/pull/140#issuecomment-1586017973 You are receiving this because you authored the thread.

Message ID: @.***>

anmonteiro commented 1 year ago

Right, depext is not going to work with Nix