Open rderoldan1 opened 10 years ago
Oh gosh, that if
elsif
block. The horror!
All joking aside, this is a rather annoying issue that you discovered @rderoldan1. I would have expected this to work, but since support for these various parts of Akami have come about piece by piece I suppose it's natural that this would have been left out.
For now, would you mind issuing this as a pull request along with a spec for this behavior? Once we have some tests, it should be easy to go and refactor this to clean up the implementation.
The patch worked for me. Thanks.
I added a new pull request #25 With this you can have timestamps and signatures at the same time and also have them signed. See the all new specs for usage examples!
Is this pull request going to get accepted? I'm having the same issue, monkey patching for now.
Also hoping for this to be accepted.
@tjarratt I just found something that I consider an issue, if signature and timestamp are true, just signature header is returned
The if clause is not considering the case of have signed? and timestamp?, I fix it (in a really ugly way) but for testing purposes it works, I don't know if is not really comment to have timestamps and the cert headers together, but what do you think?