Refactor Akami::WSSE to_xml. Signature / Timestamp no longer mutually exclusive.

savonrb / akami

Building Web Service Security

MIT License

36 stars 61 forks source link

Refactor Akami::WSSE to_xml. Signature / Timestamp no longer mutually exclusive. #18

Closed drn closed 8 years ago

drn commented 9 years ago

Ran into this when integrating with a third-party API. This pull request addresses issues raised in https://github.com/savonrb/akami/issues/15

Details:

Clean up ugly if-statement in to_xml.
Ensure certificate and timestamp headers are not mutually exclusive.
Add basic signature and signature with timestamp specs.

jim0020 commented 8 years ago

There appears to be a problem here. If the signature and timestamp both present, the timestamp hash is missing it's wsu namespace attribute. The error appears to be in WSSE#security_hash

drn commented 8 years ago

This is a couple years old and we've just patched this logic in our codebase, so I'm going to close this as it looks like it's not going to be merged.