search

savonrb / akami

Building Web Service Security
MIT License
36 stars 61 forks source link

Added support for pkcs12 #6

Closed vkoivula closed 10 months ago

vkoivula commented 12 years ago

I am not sure if pkcs12 should have own style of options when initializing with Akami::WSSE::Certs.new. However it works for now :)

shlensky commented 10 years ago

:+1:

tjarratt commented 10 years ago

Woah, I can't believe this PR languished for two+ years. I'd love to merge this in if we could get some tests added.

Would probably also be a good idea to change the documentation around these methods that would be invalidated by this change.

vkoivula commented 10 years ago

@tjarratt I haven't looked Akami lately. At the time I made this there were no tests for initialising certs and verifying signatures. There is now some new tests added for signing the documents + fixtures, so I would need to look if using pkcs12 breaks these or would needed to be tested against different fixtures. I suppose OpenSSL pretty much should take care of everything once it is just initialised with some certificate.

I might have some time look into this and would be happy hearing how you would like this to be tested :)

tjarratt commented 10 years ago

Hmm, it looks like the tests for this were mostly done in Savon. I'll have to take a look at pulling this into the master branch on Akami and see if the relevant tests are still passing with this change. If they are, it would probably be a good idea to extend the tests there with a pkcs12 case.

mrclmrvn commented 6 years ago

👍