Added support for net-http-persistent v3

savonrb / httpi

Common interface for Ruby's HTTP clients

http://httpirb.com

MIT License

300 stars 150 forks source link

Added support for net-http-persistent v3 #206

Closed baversjo closed 4 years ago

baversjo commented 5 years ago

The API for constructing new instances of Net::HTTP::Persistent changed slightly in net-http-persistent 3.x. This PR adds support for running both in v2 and v3.

coveralls commented 5 years ago

Coverage decreased (-0.1%) to 96.963% when pulling 0089e1c24fded9f587caf0a4bd967747bce072f0 on smrt:master into 2fbd6b14a0a04ed21572251580a9a4c987396e4b on savonrb:master.

micke commented 4 years ago

It would be great to get this merged and released, travis seems to have had some issue with rubygems though. Probably enough to re-run the tests.

rogerleite commented 4 years ago

Looking to Travis log, two possible solutions:

set bundler version that supports Ruby < 2.3.0 (I don't know how I need to check) or
drop support to Ruby < 2.3.0

Unfortunately, I don't have time to take care of httpi any help is welcome, I can do it on baby steps.