Support Net::HTTP::Persistent v4

savonrb / httpi

Common interface for Ruby's HTTP clients

http://httpirb.com

MIT License

301 stars 151 forks source link

Support Net::HTTP::Persistent v4 #213

Closed Meat-Chopper closed 3 years ago

Meat-Chopper commented 4 years ago

Currently HTTPI doesn't support net-http-persistent v 4.0.0. This pull request fixes it.

Meat-Chopper commented 4 years ago

Thank you for the comment! It has been applied.

rogerleite commented 4 years ago

Hey @Meat-Chopper, thanks for the contribution and @olleolleolle for the suggestion.

Somebody, please check why CI is failing? Don't seem related to the change you did but I don't have time to check it now.

Thanks in advance.

olleolleolle commented 4 years ago

Looks like: This branch is using Rake 10.x (old). And an old code coverage library version (perhaps old).

The test failure unrelated to that, has this in there: a Puma-wrapped SSL failure.

/home/travis/.rvm/gems/ruby-2.7.1/gems/puma-2.3.2/lib/puma/minissl.rb:32:in `read': OpenSSL error: error:00000001:lib(0):func(0):reason(1) - 1 (Puma::MiniSSL::SSLError)

.Exception handling servers: OpenSSL error: error:00000001:lib(0):func(0):reason(1) - 1 (Puma::MiniSSL::SSLError)

This takes more investigation & I'm far from computers for at least 10 days.

Hope these notes help!

olleolleolle commented 3 years ago

@Meat-Chopper Hi again! The issue has been resolved, and if you rebase this change, you'll see the code looks a little different, now.

coveralls commented 3 years ago

Coverage decreased (-0.006%) to 97.068% when pulling 84823040494ee22ba60ff8d258e330a4e886944a on Meat-Chopper:persistent_v4 into 91d2d19383b3f6d8c55628157a6f0f1466710866 on savonrb:master.

Meat-Chopper commented 3 years ago

Hello @olleolleolle, The rebase has been done. Thank you for fixing CI!

rogerleite commented 3 years ago

Thanks @olleolleolle for fixing the CI @Meat-Chopper thanks for the contribution

olleolleolle commented 3 years ago

No glory belongs to me, @c960657 fixed it!