search

savonrb / httpi

Common interface for Ruby's HTTP clients
http://httpirb.com
MIT License
300 stars 150 forks source link

Implement HTTPI::Auth::SSL#ciphers configuration #214

Closed c960657 closed 3 years ago

c960657 commented 3 years ago

This is an updated version of #180 by @faucct. That PR was never merged.

rogerleite commented 3 years ago

Hi Christian. First, thanks for "reopening" this PR.

Before we merge, could you please check the 2 errors HTTPI::Adapter::Curb from the tests?

Thanks, Roger Leite

c960657 commented 3 years ago

The Curb tests were also failing on master. I fixed this by changing the certs to those used in Puma tests.

I don't know what exactly was wrong with the old certificates. The certs in Puma were recently upgraded in https://github.com/puma/puma/pull/2333, but the PR just mentioned that the old certs were “outdated”.

olleolleolle commented 3 years ago

@c960657 Perhaps you can add a CHANGELOG.md line (under a new ## Unreleased heading at the top)?

Update: Thanks!

olleolleolle commented 3 years ago

Alright, all green, and now merged. Whew!

rogerleite commented 3 years ago

Thanks @c960657 and @olleolleolle 👍 good job!

edmorley commented 3 years ago

Hi - thank you for adding this :-)

I don't suppose a new httpi release could be published that includes this change? It's currently only on master. My understanding is that the released equivalent feature in savron (https://github.com/savonrb/savon/pull/794) depends on this being fixed too.