savonrb / httpi

Common interface for Ruby's HTTP clients
http://httpirb.com
MIT License
301 stars 151 forks source link

gemspec dev deps: Unpin rake, loosen puma #219

Closed olleolleolle closed 2 years ago

olleolleolle commented 3 years ago

In order to make it possible to install on Ruby 3.0.

And to avoid warnings about a CVE in Puma.

coveralls commented 3 years ago

Coverage Status

Coverage increased (+0.2%) to 97.286% when pulling 04d2e7893b65b88104b9694e64f69a5a90b2961e on gemspec-loosen-rake-newer-puma into 497a304e5d66f3670890f9611745395ecbd1cd3b on master.

olleolleolle commented 3 years ago

excon adapter fails with SSL in unknown state:

https://stackoverflow.com/questions/33572956/ruby-ssl-connect-syscall-returned-5-errno-0-state-unknown-state-opensslssl

Could need some poking.

 Excon::Error::Socket:

   SSL_connect SYSCALL returned=5 errno=0 state=unknown state (OpenSSL::SSL::SSLError)
  1) HTTPI::Adapter::Excon https requests works with client cert and key provided as file path

     Failure/Error: respond_with @client.send(method)

     Excon::Error::Socket:

       SSL_connect SYSCALL returned=5 errno=0 state=unknown state (OpenSSL::SSL::SSLError)

     # /home/travis/.rvm/gems/ruby-2.5.8/gems/excon-0.81.0/lib/excon/ssl_socket.rb:135:in `connect_nonblock'

     # /home/travis/.rvm/gems/ruby-2.5.8/gems/excon-0.81.0/lib/excon/ssl_socket.rb:135:in `initialize'

     # /home/travis/.rvm/gems/ruby-2.5.8/gems/excon-0.81.0/lib/excon/connection.rb:461:in `new'

     # /home/travis/.rvm/gems/ruby-2.5.8/gems/excon-0.81.0/lib/excon/connection.rb:461:in `socket'

     # /home/travis/.rvm/gems/ruby-2.5.8/gems/excon-0.81.0/lib/excon/connection.rb:118:in `request_call'

     # /home/travis/.rvm/gems/ruby-2.5.8/gems/excon-0.81.0/lib/excon/middlewares/mock.rb:57:in `request_call'

     # /home/travis/.rvm/gems/ruby-2.5.8/gems/excon-0.81.0/lib/excon/middlewares/instrumentor.rb:34:in `request_call'

     # /home/travis/.rvm/gems/ruby-2.5.8/gems/excon-0.81.0/lib/excon/middlewares/idempotent.rb:19:in `request_call'

     # /home/travis/.rvm/gems/ruby-2.5.8/gems/excon-0.81.0/lib/excon/middlewares/base.rb:22:in `request_call'

     # /home/travis/.rvm/gems/ruby-2.5.8/gems/excon-0.81.0/lib/excon/middlewares/base.rb:22:in `request_call'

     # /home/travis/.rvm/gems/ruby-2.5.8/gems/excon-0.81.0/lib/excon/connection.rb:273:in `request'

     # /home/travis/.rvm/gems/ruby-2.5.8/gems/excon-0.81.0/lib/excon/connection.rb:359:in `get'

     # ./lib/httpi/adapter/excon.rb:25:in `request'

     # ./lib/httpi.rb:161:in `request'

     # ./lib/httpi.rb:127:in `get'

     # ./spec/integration/excon_spec.rb:148:in `block (3 levels) in <top (required)>'

     # ------------------

     # --- Caused by: ---

     # OpenSSL::SSL::SSLError:

     #   SSL_connect SYSCALL returned=5 errno=0 state=unknown state

     #   /home/travis/.rvm/gems/ruby-2.5.8/gems/excon-0.81.0/lib/excon/ssl_socket.rb:135:in `connect_nonblock'
ioquatix commented 2 years ago

This can be closed?

olleolleolle commented 2 years ago

Thanks, yes, now closable!