search

savonrb / httpi

Common interface for Ruby's HTTP clients
http://httpirb.com
MIT License
301 stars 151 forks source link

Can we remove socksify as a dependency? #224

Closed ioquatix closed 2 years ago

ioquatix commented 2 years ago

https://github.com/savonrb/httpi/blob/497a304e5d66f3670890f9611745395ecbd1cd3b/httpi.gemspec#L19

It would be awesome if we can make this an optional dependency because we are concerned about thread safety issues it might introduce - and also it looks abandoned.

olleolleolle commented 2 years ago

Sure, I think we can! People who need it, they can get a nice message about what they need to do.

Would you be interested in making a PR?

ioquatix commented 2 years ago

Haha, it's you!

What a small world.

Okay, sure, PR will be en-route.

ioquatix commented 2 years ago

At some point can we please cut a major release with this? Thanks :)