search

savonrb / httpi

Common interface for Ruby's HTTP clients
http://httpirb.com
MIT License
301 stars 151 forks source link

Make socksify and rack gem dependencies optional #225

Closed ioquatix closed 2 years ago

ioquatix commented 2 years ago

Fixes #224. Fixes #205.

olleolleolle commented 2 years ago

I am frantically pushing APPROVE AND RUN

olleolleolle commented 2 years ago

So, I think this is at the place where we need to look at things we can extract from it, and offer to the default branch.

A way forward with this big a change is a new major version, which allows to shed old version support etc.

olleolleolle commented 2 years ago

In addition to the earlier things fixed, the CI issue is also fixed by this.

pcai commented 2 years ago

Thank you for your work on this.

olleolleolle commented 2 years ago

This has now been released as 3.0.0. https://github.com/savonrb/httpi/releases/tag/v3.0.0

ioquatix commented 2 years ago

Thank you so much.