search

savonrb / httpi

Common interface for Ruby's HTTP clients
http://httpirb.com
MIT License
301 stars 151 forks source link

Rack::Utils::HeaderHash --> Rack::Headers #239

Closed Nathan-Yorio closed 7 months ago

Nathan-Yorio commented 1 year ago

This in request.rb is deprecated syntax according to my builds. 

  # Returns a Hash of HTTP headers. Defaults to return an empty Hash.
  def headers
    @headers ||= Rack::Utils::HeaderHash.new
  end

  Rack::Utils::HeaderHash is deprecated and will be removed in Rack 3.1, switch to Rack::Headers
pcai commented 7 months ago

fixed in https://github.com/savonrb/httpi/commit/56cd67bf0da61c39552be1d9fc9bff6f33315284

mvz commented 7 months ago

This breaks compatibility with Rack 2 so httpi should not allow that version of rack anymore.