search

savonrb / nori

XML to Hash translator
MIT License
245 stars 74 forks source link

Stop monkey-patching String with #snakecase #102

Closed mchu closed 6 months ago

mchu commented 6 months ago

What kind of change is this? Fixes #101

Stops the monkey patching of #snakecase onto String.

Did you add tests for your changes? Updated existing String#snakecase tests to test Nori::StringUtils.snakecase.

Summary of changes Moved String#snakecase into a module class method.

Other information Related to https://github.com/savonrb/savon/issues/984

choosen commented 1 week ago

Savon gave it breaking change, not monkeyPatch

BC BREAKING Fix: #988 Savon no longer monkeypatches String#snakecase

You changed the util so it's hard to be compatible with Nori when somebody used pointed out in readme before 'StringKey'.snakecase

It's of course good to not pollute String class, but it should be minor bump I suppose instead of bugfix

pcai commented 1 week ago

Yes in hindsight it would’ve been a point release as with Savon - sorry about that