search

savonrb / savon-multipart

Heavy metal Ruby SOAP client with multipart support
MIT License
17 stars 47 forks source link

Test soap faults #13

Closed dwilkie closed 9 years ago

dwilkie commented 10 years ago

This PR tests the fix added to Savon here: https://github.com/savonrb/savon/pull/595

Once https://github.com/savonrb/savon/pull/595 is merged into master, and the dependency is bumped, this test will pass.

dwilkie commented 10 years ago

@tjarratt any news on this one and https://github.com/savonrb/savon/issues/595 ?

tjarratt commented 9 years ago

Hey @dwilkie I'm truly sorry I was silent on this issue for so long. My child was born in mid July, which kind of threw a giant wrench in my life as far as contributing to OSS projects is concerned. Not an excuse, but just a reason for the silence, really.

I really can't remember what went through my sleep deprived head when I read this back in July, but I'd have to guess that the crazy amount of changes in the diff were the cause. Looking at it now, it seems perfectly fine, but it wasn't obvious by looking at the total diff that you had just used some context blocks to clean this up.

Thanks for taking the time to submit this!