search

savonrb / savon-multipart

Heavy metal Ruby SOAP client with multipart support
MIT License
17 stars 47 forks source link

Latest master compatible with savon2? #14

Closed rngtng closed 9 years ago

rngtng commented 9 years ago

I'm confused with the Readme saying "use branch 'savon2' with when running savon >= 2.0 ". I just did, but it didn't work with latest savon version (as of gemspec dependencu on savon 2.1).

Instead latest savon-multipart gem just worked fine with latest savon

So is Readme outdated and the note about savon 2 should be removed??

rngtng commented 9 years ago

cool thx, can the branch savon2 be deleted as well?

ebeigarts commented 9 years ago

I'm not sure if we need to remove it, maybe someone is still using that branch (gem 'savon-multipart', github: ..., branch: 'savon2').

rngtng commented 9 years ago

hm true, good point, but I wonder what's best practice to deprecate & remove branches? I find it confusing..