savonrb / savon-multipart

Heavy metal Ruby SOAP client with multipart support
MIT License
17 stars 47 forks source link

Support Savon version 2 requests #7

Closed tjarratt closed 10 years ago

tjarratt commented 11 years ago

I wanted to use Savon version 2 and despaired that savon-multipart did not support it, so I've updated this gem and cleaned up as much of the low hanging fruit as I could.

The corresponding pull request for Savon is here

tjarratt commented 11 years ago

Just started using this a bit more in production, fixed a bug with the #body method where Nori couldn't parse the Mail::Body object we were returning from #to_xml

rubiii commented 11 years ago

@tjarratt i just merged savonrb/savon#434 and added you as a maintainer to the savonrb organization. remember, with great power comes great responsibility :)

@tjarratt @ebeigarts do you both have an account at rubygems.org? if you give me your email address associated with that account, i will add you as an owner for the multipart gem so you can release on your own schedule.

tjarratt commented 11 years ago

Ah, many thanks @rubiii -- I promise to always use this power for good, and to never let my passwords fall into the wrong hands :)

I'm "nearbuy_tim" on rubygems.org, but I'm fine delegating to @ebeigarts for future releases. My projects' Gemfiles already specify a branch, and it isn't much work to maintain that much until a new release.

soundarapandian commented 11 years ago

:+1:

Hi folks I would like to thank all of you for giving savon 2 support to savon-multipart.

rubiii commented 11 years ago

@soundarapandian i hear you :)

i'll make sure this gets released for version 2 after the "push to github" milestone of savonrb/wasabi#27 is done.

tjarratt commented 10 years ago

This has been merged for some time now. Closing since I just published a new version to ruby gems.org

tjarratt commented 10 years ago

Feels so weird to merge and close my own pull request, but whatever. C'est la vie.