search

savonrb / savon

Heavy metal SOAP client
https://www.savonrb.com
MIT License
2.07k stars 616 forks source link

Breaking changes from 2.13.0 #1014

Open aovertus opened 2 months ago

aovertus commented 2 months ago

Bug report

We had to rollback to 2.12.0, I bisect the different and found that https://github.com/savonrb/savon/pull/943/files#diff-5a4c518121b3117561233cad78d43354f8424514a186ddd1459ab431178a667eR130-R137

introduced a breaking change on our side, our provide to which I don't have support neither code access do not support the updated payload. Is there a way to bypass this change aside of monkey patch the gem itself ?

Current behavior: SOAP calls are not accepted by our provider anymore

Steps to reproduce current behavior: Won't help much without the full payload but here is a sample

Wasabi::Document.new("https://sync.rex11.com/ws/v4staging/publicapiws.asmx?WSDL")
body = Savon::Builder.new('PickTicketAdd', Base::WSDL_OBJECT, Base::SAVON_GLOBAL_OPTION, {message: payload}).to_s

Expected behavior:

SOAP calls are accepted by our provider

System information:

pcai commented 2 months ago

Thank you for the bisect but this doesn’t give me enough info to fix, and obviously I can’t just roll back that change since its a fix for https://github.com/savonrb/savon/issues/224

Can you at least provide the response from the server? What doesn’t it like? And an anonymized before/after of the structure of the payload