Closed olleolleolle closed 2 years ago
What kind of change is this?
The HTTP client for Savon is httpi. It got a new major release, with https://github.com/savonrb/httpi/releases/tag/v3.0.0 which has a breaking change.
Did you add tests for your changes?
No, our current tests should do their job.
Summary of changes
Only people who use the features that the Rack Adapter and Socksify gem offer should need them in their dependency graph. Socksify amends classes with some monkey-patches, that some people may not want.
What kind of change is this?
The HTTP client for Savon is httpi. It got a new major release, with https://github.com/savonrb/httpi/releases/tag/v3.0.0 which has a breaking change.
Did you add tests for your changes?
No, our current tests should do their job.
Summary of changes
Only people who use the features that the Rack Adapter and Socksify gem offer should need them in their dependency graph. Socksify amends classes with some monkey-patches, that some people may not want.