Closed dduugg closed 2 years ago
I went back to e090cc5 which added the fixture file for "brands" which is involved in this test.
That commit fails the same way for this test.
Now, the "RPC-encoded WSDL" support, I think we rolled that back, in Wasabi, I may misremember. But: I didn't misremember https://github.com/savonrb/wasabi/pull/103
Here's another trace of "when that was introduced in savon": https://github.com/savonrb/savon/issues/699#issuecomment-191528690
I'm leaning towards:
Hi @olleolleolle, thanks for the context and hints. This is all a bit out of my wheelhouse though, so I'll close and defer resolution to you. Hope that seems reasonable. Thanks again for your time and energy.
What kind of change is this?
bugfix
Did you add tests for your changes?
Fixes a failing test observed in https://github.com/savonrb/savon/pull/972 and which also fails on the
master
branch.Summary of changes
Updates the expectation to match the output. (I'm not familiar enough with the code to understand if this is a reasonable fix, or if the failure represents an underlying bug that should instead be patched.)
Other information