search

savonrb / savon

Heavy metal SOAP client
https://www.savonrb.com
MIT License
2.07k stars 616 forks source link

[Bugfix] Preventing xmlns:xmlns namespace #977

Closed VictorPS closed 2 years ago

VictorPS commented 2 years ago

What kind of change is this?

Bugfix to prevent "xmlns:xmlns" namespace which is an invalid namespace.

Did you add tests for your changes?

I have updated the spec to ensure that the namespaces are the correct ones.

Summary of changes

2.13.0 introduced a new bug where it was adding a namespace "xmlns:xmlns" to the envelope and this was resulting in an invalid XML.

Other information

When I forked the repo rake spec:integration was failing, this change seems to have fixed it as well. This has fixed an issue I am having in my application as well.

Related issues: https://github.com/savonrb/savon/issues/976 https://github.com/savonrb/savon/pull/943#issuecomment-1213163418

olleolleolle commented 2 years ago

Thanks, this is super!

cgunther commented 2 years ago

Thanks for the fix, merge, and release. Confirmed this fixed the problem for me.