search

savonrb / savon

Heavy metal SOAP client
https://www.savonrb.com
MIT License
2.07k stars 616 forks source link

Fix #986 do not include xmlns namespace from WSDL #989

Closed nathansamson closed 1 year ago

nathansamson commented 1 year ago

What kind of change is this?

Bugfix for #986

Did you add tests for your changes?

Changed test Summary of changes

Exclude xmlns coming from WSDL as this causes issues for some servers, and is genreally not needed

Other information

Not yet checked with my server implementation but intend to do so soon

nathansamson commented 1 year ago

Checked this on server that was giving me issues before and I can confirm this fixes my issue

pcai commented 1 year ago

Need to investigate why the tests are now failing

pcai commented 1 year ago

ok it appears to be failing on master too, I confirmed this was due to a recent release of mail 2.8.0 which broke a test, this is now fixed. This can merge once everything is confirmed green with that fix

Edit: This worked locally with the patch from main applied. Thanks!