search

savonrb / sekken

Sekken is a new experimental SOAP client for ruby
MIT License
18 stars 25 forks source link

Faraday instead HTTPClient #15

Open sheerun opened 9 years ago

sheerun commented 9 years ago

Faraday is an abstraction layer for http clients in ruby.

HttpClient is one of its backends, but there are great alternatives.

Could you switch sekken to use faraday instead?

sheerun commented 9 years ago

or httpie ;)

tjarratt commented 9 years ago

Hey @sheerun thanks for pointing this out. It's been quite a while since I've taken a step back and asked what the Ruby community is using for HTTP clients (and abstractions around them).

Would you be interested in submitting a pull request to bring in Faraday to Sekken?

comandeo commented 9 years ago

I tried to work on that issue and struggled with a 'bug' in faraday - https://github.com/lostisland/faraday/issues/428

I do not think it makes any sense to work on this ticket before Faraday guys clarify the situation somehow.

tjarratt commented 9 years ago

That's unfortunate. I have to say, your face-palm avatar is strangely appropriate, given the "bug" you filed against Faraday.

tsyber1an commented 9 years ago

i'm looking forward to extract that dependency to abstract layer, @tjarratt what do you think about it?