Add Ruby 3 to run on TravisCI

savonrb / wasabi

A simple WSDL parser

MIT License

90 stars 84 forks source link

Add Ruby 3 to run on TravisCI #102

Closed bvicenzo closed 3 years ago

bvicenzo commented 3 years ago

Just configuring Travis CI to run tests using the new Ruby version 3.0

olleolleolle commented 3 years ago

rubysl-fcntl (~> 1.0) was resolved to 1.0.0, which depends o

rubysl = Ruby Standard lib for Rubinius. Perhaps we need to... do something about that?

coveralls commented 3 years ago

Coverage remained the same at 98.413% when pulling b6653edfba2904dbb5dcb256a219ede9408e9d52 on bvicenzo:bv-add-ruby-3-on-travisci into 665e78d713ef051ee4bae2dc5e2b1aa135916a17 on savonrb:master.

bvicenzo commented 3 years ago

rubysl-fcntl (~> 1.0) was resolved to 1.0.0, which depends o

rubysl = Ruby Standard lib for Rubinius. Perhaps we need to... do something about that?

Wow... I've not gotten this error on my machine... It seems that we need to take a look 🤔

olleolleolle commented 3 years ago

Perhaps we can:

(My recommendation) Drop Rubinius from the CI matrix & Gemfile due to its conflicts with latest stable Ruby
OR: Introduce a --without rubinius bundle option, for all but the rubinius build. https://bundler.io/v2.2/man/bundle-config.1.html#LIST-OF-AVAILABLE-KEYS mentions BUNDLE_WITHOUT as an env var, which is easier to manipulate in the CI matrix.

bvicenzo commented 3 years ago

@olleolleolle It sounds strange... These gems are scoped in the platform rbx. And bundle doc says that this scope would be enough to not install those gems on the wrong platform 🤔.

Do we have the intention of keeping official support for Rubinius yet?

olleolleolle commented 3 years ago

@bvicenzo We're not going to have an easy time supporting Rubinius. My vote would be "remove support".