savonrb / wasabi

A simple WSDL parser
MIT License
90 stars 84 forks source link

4.0 release breaks integration with `style="rpc"` operations #118

Closed hss-mateus closed 8 months ago

hss-mateus commented 8 months ago

If I understand it correctly, PR #114 added a check in the style attribute of an operation to know if it's an document.

https://github.com/savonrb/wasabi/blob/3bf250213e842c1207d39ee7891288160686574f/lib/wasabi/parser.rb#L147

Apparently, a comparison is missing here, so it's always considering that it's a document style. A solution is to just compare with the desired value:

 soap_document = soap_operation["style"] == "document" if soap_operation
pcai commented 8 months ago

Thanks. Can you provide a pr with a test case please?