Ordered type elements - Githubissues

leoping commented 12 years ago

Hello,

We are working on code which dynamically reads WSDL files using wasabi, and makes savon requests based on the content of the file. We identified the following changes to be required for us to do this:

Adding :order! attribute to the types hash, which specifies the order of the type elements as defined by the WSDL source file. This makes wasabi compatible with Ruby 1.8, and also consistent with Savon, which allows passing an :order! attribute for Ruby 1.8 users to specify the order (as described in http://savonrb.com/#executing-soap-requests)
Changed merging of type attributes logic so that subclass attributes are not overwritten by base class attributes
Added additional information about the type attributes: :nillable, :minOccurs, :maxOccurs). This is in addition to the already-present :type attribute.

We have tested our changes against the wasabi specs, as well as the specs of savon and savon-multipart, and they all pass (on a local test machine).

rubiii commented 11 years ago

this should finally be solved by 4.0.0.

rubiii commented 11 years ago

i would like to get rid of the order parameter for the next (probably major) savon release. with the new code on master we should be able to properly determine the order of elements. i don't think there are any tests for this right now, but i'll add it to some todo list.

sorry this hasn't been updated, but i really needed to get these changes out so we have a somewhat sane architecture instead of xpath hell!

leoping commented 11 years ago

Thanks @rubiii, we'll try out the latest version soon. So 4.0.0 has addressed all 3 items mentioned above?

rubiii commented 11 years ago

@leoping it's not ready yet, but i'm working on integration it into savon right now.

specifying the :order! should not be necessary after this.
regarding subclass-merging i need to look at your changes.
these will be used to determine the number of occurrences.

please follow #27 for updates and let me know if i'm missing something.

rubiii commented 11 years ago

@leoping merged these changes as well. they're on master and planned to be released with wasabi v3.2.0. please let me know if this works for you.

savonrb / wasabi

Ordered type elements #16