search

savonrb / wasabi

A simple WSDL parser
MIT License
90 stars 84 forks source link

Does not follow 3xx redirects #18

Open zacharydanger opened 11 years ago

zacharydanger commented 11 years ago

For instance the WSDL: https://services.PWSDemo.com/CreditCardTransactionService.svc?wsdl

This produces a 307 redirect with a location header. Instead of following the redirect, it assumes there's been an error and raises an HTTPError.

rubiii commented 11 years ago

this will be fixed with savon version 3 by handing the control of http-requests to the user.

dfoleyAFG commented 10 years ago

Is this fixed? I am having the same problem...

tjarratt commented 10 years ago

@dfoleyAFG it's still an unresolved issue. From looking at the discussion on the still-open HTTPI issue, it seems like it wasn't clear whether this should be fixed in Wasabi or HTTPI. It seems fairly straightforward to fix, but reading some of the history... it does reveal itself to be rather complicated.

If someone issued a PR (with tests) for this behavior to Wasabi or HTTPI I'd definitely try to get it merged in. Right now I'm learning towards implementing it in Wasabi because of some quirks in getting all of the adapters to support this.

Interested parties might want to read https://github.com/savonrb/httpi/issues/67 for some more history, information and discussion about how this might be solved.