search

savonrb / wasabi

A simple WSDL parser
MIT License
90 stars 84 forks source link

Updated nokogiri to 1.6.0 #31

Closed rafamanzo closed 10 years ago

rafamanzo commented 11 years ago

Hi, first of all thanks for the great work! We've been using savon for years!

I'm not sure if there are any known issues regarding this update. I've had a quick look on the closed ones and found nothing.

So, I updated nokogiri because to be stuck with 1.5.10 is really annoying every time you run bundle update if you also use cucumber.

Again, I'm not sure if this working properly, but the specs are OK and, I've already ran the savon specs (including integration ones) without problems here: https://github.com/rafamanzo/savon/tree/version2-nokogiri-1.6 So what do you think?

Thanks again and sorry if I'm completly wrong!

coveralls commented 11 years ago

Coverage Status

Coverage remained the same when pulling b46e18cac3fbda20461e7d7e56a7ab7bf06a86ff on rafamanzo:nokogiri-1.6 into ccf7be658d62a607dbdc04ccf259f675f4ec6b79 on savonrb:master.

tjarratt commented 10 years ago

Sorry for the delay, but this finally got merged in recently. This was version locked to Nokogiri <= 1.6 because we were still supporting ruby 1.8.7.

Really appreciate the pull request, and again, I'm sorry this wasn't merged in sooner!