search

savonrb / wasabi

A simple WSDL parser
MIT License
90 stars 84 forks source link

support port type input/output without message namespace #33

Closed mikeantonelli closed 10 years ago

mikeantonelli commented 10 years ago

The parser assumes the presence of a : when iterating over the port types in the message attribute separating the message namespace and the message type 1. In some cases, I've found WSDL definitions that do not contain a message namespace which results in an exception being thrown by the parser:

lib/wasabi/parser.rb:264:in 'input_output_for': undefined method 'element_children' for nil:NilClass (NoMethodError)

dmcclory commented 10 years ago

I encountered the same exception and @mikeantonelli's patch cleared it up. Upvote for merging it in.

tjarratt commented 10 years ago

Thanks for reporting and fixing this issue @mikeantonelli. Looks like the tests weren't that extensive, but this seems like a fairly straightforward fix.