Allow support for newer versions of Nokogiri when using Ruby > 1.8

savonrb / wasabi

A simple WSDL parser

MIT License

90 stars 84 forks source link

Allow support for newer versions of Nokogiri when using Ruby > 1.8 #35

Closed benjamin closed 10 years ago

benjamin commented 11 years ago

This same approach is used in the Savon gemspec (version2 branch), however due to the Wasabi dependency we were still not able to update to Nokogiri 1.6.

coveralls commented 11 years ago

Coverage remained the same when pulling 88268c0e75d73d521608b46e0b86d6a0aaa41627 on hooroo:master into ccf7be658d62a607dbdc04ccf259f675f4ec6b79 on savonrb:master.

tanelsuurhans commented 11 years ago

Whats the status on this? This obviously still is a problem when using savon 2.3.0

tjarratt commented 10 years ago

I think this looks good -- the build passed on ruby 1.9 and later. I'm trying to get the build green for 1.8.7 before merging this in, but it should be fairly straightforward.

Beginning to think that we should just drop support for ruby 1.8 in a new release, so that we can avoid these sorts of problems moving forward.

tjarratt commented 10 years ago

Merged from the command line in commit https://github.com/savonrb/wasabi/commit/03a6404a867ed195111c15c5e609fc2fa821f24f