removed nokogiri 1.6 dependency

savonrb / wasabi

A simple WSDL parser

MIT License

90 stars 84 forks source link

removed nokogiri 1.6 dependency #37

Closed gaaady closed 10 years ago

coveralls commented 10 years ago

Coverage remained the same when pulling b33f2967ba5e4aa09302144a95f30485c714e989 on gaaady:master into b10381c00dec6c817e2a5410f9a0c3fe6210271c on savonrb:master.

tjarratt commented 10 years ago

I think instead of removing the restriction for nokogiri <= 1.6 on ruby 1.8, we should probably just drop support for ruby 1.8 entirely. This PR probably isn't needed, since ruby 1.9 + doesn't have the restriction.

gaaady commented 10 years ago

I'm on ruby 2.0 and wasabi caused installation problems. maybe we should drop the condition regarding ruby 1.8.7

tjarratt commented 10 years ago

Dropped support for ruby 1.8 in caa9ef3e0af9336f9a40ebc99c717461a50739c8. The only requirement for nokogiri now is >= 1.4, so I think we can close this now. Please re-open if this isn't resolved for you, @gaaady.