Failing spec for issue #562

davidsantoso commented 10 years ago

Here's a failing spec for #562 which follows up on some regressions that seemed to have been reverted in PR #39. Hopefully this kicks off a bit of discussion on how best to move forward with the logic behind properly setting the message tag.

In the case of issue #562, element may not work for setting the message_tag. This section of the parser in particular may need to be refactored a bit to accommodate this WSDL and others like it.

Here's the snippet from the WSDL:

<wsdl:message name="writeCaseEformData">
      <wsdl:part element="flt:FLEformFields" name="WriteCaseEform"/>
</wsdl:message>

<wsdl:operation name="writeCaseEformData">
       <wsdl:input message="fls:writeCaseEformData"/>
       <wsdl:output message="fls:writeCaseEformDataResponse"/>
       <wsdl:fault message="fls:serviceException" name="serviceException"/>
</wsdl:operation>

davidsantoso commented 10 years ago

Forgot to squash some commits! I'll close and resend.

tjarratt commented 10 years ago

Protip: if you rebase, squash and force push to your branch, your pull request gets updated automatically. Opening another PR is cool too, though =D

davidsantoso commented 10 years ago

Ahh, learn new things everyday. Thanks for the tip! I'll try that next time. ;)

coveralls commented 10 years ago

Coverage remained the same when pulling 43deeb6692c17d9bfbdf03c1666500b8417411a1 on davidsantoso:issue-562 into cd191deedf71928f5b2741e76c8ee314d89ff4b9 on savonrb:master.

savonrb / wasabi

Failing spec for issue #562 #45