search

savonrb / wasabi

A simple WSDL parser
MIT License
90 stars 84 forks source link

Convert spaces to underlines #60

Closed kukareka closed 9 years ago

kukareka commented 9 years ago

Convert strings like "This week" to "this_week" with String#snakecase. Fix #59.

tjarratt commented 9 years ago

I'm not sure if this is preferable to simply not polluting the String class with our monkey patches. For one, it doesn't seem likely that Wasabi would ever need to handle words with spaces in them, but it also seems like we should consistently use the same snakecase method, regardless of which order Savon and other projects are required in.

tjarratt commented 9 years ago

I do appreciate the issue and the pull request though, @kukareka.