search

savonrb / wasabi

A simple WSDL parser
MIT License
90 stars 84 forks source link

Remove deprecated URI escape/unescape calls #74

Closed brittballard closed 4 years ago

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at ?% when pulling 95aaf089c08f4336712165d96182fe4067ccc0e5 on brittballard:savonrb/wasabi into 8cc2658754d3e66831ae60ad43c7561d5142daed on savonrb:master.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at ?% when pulling 95aaf089c08f4336712165d96182fe4067ccc0e5 on brittballard:savonrb/wasabi into 8cc2658754d3e66831ae60ad43c7561d5142daed on savonrb:master.

olleolleolle commented 4 years ago

@brittballard Hi! This seems to change behavior, and the test failures seem to be about escaping.

https://travis-ci.org/github/savonrb/wasabi/jobs/632112038#L283

Here's a StackOverflow note about the difference between the two methods: https://stackoverflow.com/questions/30783879/whats-the-difference-between-cgi-unescape-and-uri-decode-www-form-component

olleolleolle commented 4 years ago

Aha, there's been additoinal fixes, in #75: https://github.com/savonrb/wasabi/pull/75/commits/f6ab0a50900cde84f05c5ac09b82f48a11e54948

olleolleolle commented 4 years ago

Thanks for offering a PR! <3

Fixed in #81