savonrb / wasabi

A simple WSDL parser
MIT License
90 stars 84 forks source link

Remove Ruby 2.7.0 warnings #75

Closed bvicenzo closed 4 years ago

bvicenzo commented 4 years ago

This PR implements:

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-84.1%) to 0.0% when pulling abc869f4c80d15b5cf527cc8a938732a5b7bb94d on bvicenzo:bv-remove-ruby-2-7-0-warnings into 8cc2658754d3e66831ae60ad43c7561d5142daed on savonrb:master.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at ?% when pulling 51210c29a23e56205c656d10ae00593c34e47a2a on bvicenzo:bv-remove-ruby-2-7-0-warnings into 8cc2658754d3e66831ae60ad43c7561d5142daed on savonrb:master.

bilby91 commented 4 years ago

Any ETA for merging this MR ?

coding-bunny commented 4 years ago

Can we have an update on this? The spam from Wasabi in test-suites makes it really hard to get usable output.

bvicenzo commented 4 years ago

@olleolleolle Nice! suggestions applied.

olleolleolle commented 4 years ago

Cool, thanks for the perseverance!

bilby91 commented 4 years ago

Any ETA for merging this one ?

bvicenzo commented 4 years ago

@olleolleolle Considerations Done. Thanks.

olleolleolle commented 4 years ago

Thanks, @bvicenzo!

Most of the changes have been integrated into master now, and I will close this PR, many of its commits are in the project already.

Thanks to @chaymaeBZ who did the navigating and fixing!

Many cheers! 🎉

bvicenzo commented 4 years ago

@olleolleolle Very thanks. Please, let me know when we have a new gem version.

olleolleolle commented 4 years ago

I can recommend trying it out using a git dependency in your Gemfile - or using the gem "specific_install", which lets you install git versions of gems.

That forms a part of our "community QA", which strengthens upcoming releases.

bvicenzo commented 4 years ago

Thanks, I use dependabot to do this... I follow there so. Thanks 😄