savonrb / wasabi

A simple WSDL parser
MIT License
90 stars 84 forks source link

Drop `git ls-files` in gemspec #89

Closed utkarsh2102 closed 4 years ago

utkarsh2102 commented 4 years ago

Hi @olleolleolle,

Thanks for maintaining this so far! :heart: As discussed in #68, this PR drops the usage of git to list the files and only ships the files that are necessary for end-users :rocket:

Closes: #68

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 0.0% when pulling 7ce601cdcd3ca16131f9a3c34b8d023cccd04636 on utkarsh2102:drop-git into 0ee89584033884a139e5f92fc842af4db1dc7ca0 on savonrb:master.

olleolleolle commented 4 years ago

@utkarsh2102 To make this PR mergeable now, without any other changes, please omit the rubocop-packaging change. It's a good idea, but other changes are needed to include it, now.

rubocop-packaging (~> 0.1.1) was resolved to 0.1.1, which depends on

      ruby (>= 2.3.0)
utkarsh2102 commented 4 years ago

Hi @olleolleolle,

Eeks, I am sorry, I should've checked! :/ How about this diff:

--- a/Gemfile
+++ b/Gemfile
@@ -5,6 +5,10 @@ gem 'simplecov',       :require => false
 gem 'method_profiler', :require => false
 gem 'coveralls',       :require => false

+if RUBY_VERSION >= '2.3'
+  gem 'rubocop-packaging',  :require => false
+end
+
 platform :rbx do
   gem 'json'
   gem 'racc'

I hope that's better and okay?

olleolleolle commented 4 years ago

It's alright if the build gets to green, try it!

utkarsh2102 commented 4 years ago

Sorry for not checking the build failures earlier (my bad!). Green again! :tada: