Closed utkarsh2102 closed 4 years ago
@utkarsh2102 To make this PR mergeable now, without any other changes, please omit the rubocop-packaging
change.
It's a good idea, but other changes are needed to include it, now.
rubocop-packaging (~> 0.1.1) was resolved to 0.1.1, which depends on
ruby (>= 2.3.0)
Hi @olleolleolle,
Eeks, I am sorry, I should've checked! :/ How about this diff:
--- a/Gemfile
+++ b/Gemfile
@@ -5,6 +5,10 @@ gem 'simplecov', :require => false
gem 'method_profiler', :require => false
gem 'coveralls', :require => false
+if RUBY_VERSION >= '2.3'
+ gem 'rubocop-packaging', :require => false
+end
+
platform :rbx do
gem 'json'
gem 'racc'
I hope that's better and okay?
It's alright if the build gets to green, try it!
Sorry for not checking the build failures earlier (my bad!). Green again! :tada:
Hi @olleolleolle,
Thanks for maintaining this so far! :heart: As discussed in #68, this PR drops the usage of
git
to list the files and only ships the files that are necessary for end-users :rocket:Closes: #68
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>