search

savq / melange-nvim

🗡️ Warm color scheme for Neovim and beyond
MIT License
719 stars 55 forks source link

Contrast between hl-DiffChange and hl-DiffText on the light theme is too low... right? #57

Open aintyourcat opened 1 year ago

aintyourcat commented 1 year ago

Hello! thanks for the colorscheme, been using it for a while now :D

However, as the title said, i have a little problem regarding the colors of the diff on the light theme, to be more specific with the changed part (did a little research, i think its related with the DiffChange and DiffText highlights, but I'm unsure about it).

Here is how it looks like when i did :Gvdiffsplit (with fugitive.vim)...

2023-03-25_15-47

... compared with vscode.nvim.

2023-03-25_15-48

savq commented 1 year ago

Yes, this could be improved! The saturation could be increated to have more contrast.

It'd also be a good idea to use a different hue for DiffText. In dark mode it's not that bad, but in light mode it's really hard to distinguish the light blue from the light purple (because of the Abney effect).

I'm not sure what would be better. The red in your screenshot has good contrast, but red is usually used for deleted text 🤔 Maybe keep magenta for DiffChange and use red just for DiffText?