savq / melange-nvim

🗡️ Warm color scheme for Neovim and beyond
MIT License
697 stars 51 forks source link

Add Lightline theme #85

Closed Nandax00 closed 2 months ago

Nandax00 commented 2 months ago

Now using the defined palettes.

Modes: image image image image

Tabline: image

savq commented 2 months ago

Looks good. Just a couple of questions:

I'd maybe swap visual and replace, so insert and replace both use warm colors.

Nandax00 commented 2 months ago
* All the zeros are for `cterm` colors, right?

Yes, I didn't try to emulate these colors in cterm, probably a disclaimer would make sense.

  • Can lightline tell the difference between visual and block-visual? No, Visual, V-Block, V-Line are all colored by s:p.visual
  • Could normal mode use a simpler gray color? I'm used to a very simple status line, but if other colorschemes use colors for normal node, then I guess it's fine. I was using the gruvbox theme for a long time before I switched to melange, and so I tried to emulate the color choices of its status line here. Btw, most of the included themes have non-gray normal mode colors: https://github.com/itchyny/lightline.vim/blob/master/colorscheme.md . EDIT: I've just checked gruvbox, and it actually uses gray in Normal, so nevermind. Would you go then with gray or colored? I'd maybe swap visual and replace, so insert and replace both use warm colors.

I, personally, use the visual mode most often to select an arbitrary section, and then change that via c, so for me the stronger yellow color makes a lot of sense here. On the other hand, I never ever used Replace mode :D How about meeting in the middle: let's change "replace" to magenta?

savq commented 2 months ago

Ok. Then the changes I'd suggest are:

Nandax00 commented 2 months ago

It's not possible to config the Command mode with Lightline, it seems. I've applied your other suggestions.

savq commented 2 months ago

Perfect. Thanks @Nandax00 for the PR!