Closed prak112 closed 1 month ago
FYI, I'll continue reviewing once the package.json issue is addressed.
Okay. I've got it running now. Using Vite is working out. We can keep that. But the UI changes, those need to be reverted.
We do have an issue (#16 ) to set the default pages (so that you first see the login page, with a create user option, and then once logged in see the home page. From there, you could create a step). So that will be addressed soon.
This PR should be about the plumbing, the infrastucture, but nothing the user sees should change in this PR. See #16
// work-app-frontend/src/components/Home.jsx ....
/**
* Redirects to the authentication page.
*/
// const verifyUser = () => {
// // if authorized navigate to steps
// // if not, navigate to signup and then login
// }
....
- This redirection logic needs to be implemented via [UserContext.jsx](https://github.com/prak112/savvato-work-app-frontend-app/tree/issue19/migrate-to-vite/work-app-frontend/src/contexts)
- My motivation to change the UI was to give a sneak-peek to the user on what exactly the application does. Since it is not clear in any way about what the application is.
- Also, when a user is just asked to register without giving an idea of what they are registering for, would be cruel.
- Consider this and let me know. I will redo the changes if you are not convinced of my logic.
Sorry about that. Still learning to work with PRs and reviewing 😄
The Unix Principle, do one thing and do it well.. is my motivation here! :)
I just realized I did not, at least in this PR, directly respond to your last message.
"My motivation to change the UI was to give a sneak-peek to the user on what exactly the application does. .. [and more good points].."
I'm not convinced :) I would respond that the user is not looking at these changes. They are all valid, and useful, certainly as proof of concept. But they belong in a separate PR. Your audience here is other developers, not the end user. Gotta make the PRs for developers, even when they benefit the end user.