search

savvato-software / tribe-app-backend

3 stars 20 forks source link

TRIB-12: update all loggers to use Lombok @Slf4j #228

Closed mrsbluerose closed 5 months ago

mrsbluerose commented 5 months ago

Update any older loggers to Lombok's @Slf4j annotation and "log.---"

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.72%. Comparing base (4b90ca1) to head (ee07fad). Report is 3 commits behind head on develop.

Files Patch % Lines
.../com/savvato/tribeapp/services/StorageService.java 62.50% 3 Missing :warning:
.../savvato/tribeapp/services/PictureServiceImpl.java 91.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #228 +/- ## ============================================= + Coverage 81.36% 82.72% +1.35% - Complexity 545 557 +12 ============================================= Files 78 79 +1 Lines 1685 1696 +11 Branches 274 274 ============================================= + Hits 1371 1403 +32 + Misses 279 254 -25 - Partials 35 39 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mrsbluerose commented 5 months ago

Question: The ticket asks for documentation. To see the logger, we do need to add the following to our application.properties file: logging.level.com=DEBUG

Should I add this to the DEVELOPER file? or where should we add documentation of this nature?

mrsbluerose commented 5 months ago

added picture service testing. Consulting on these changes in meeting 6/25 to see if this is the approach we want to take.

haxwell commented 5 months ago

Regarding the logger, sure, I think we can create a LOGGING or DEBUGGING section in the DEVELOPER file, and mention that setting there. And you probably do not want to add logging.level.com=DEBUG because that would show the DEBUG messaged from everything, It is best to be a little more specific, and use a setting like logging.level.com.savvato.tribeapp.controllers.FileUploadController=DEBUG so only the messages from that class are shown (if they're DEBUG or higher level msgs). logging.level.com.savvato.tribeapp.controllers=DEBUG would show all the message for all the controllers.